Merged
Conversation
TODO: 1) Account for associated journals such as attachments, ensure those are restricted 2) Exclude restricted journals from aggregation? (Unclear) 3) Exclude comment-only journals from "snapshots" i.e. making a copy of the current wp state
Atm, the "restricted" concept only exists for comments - aka "Journal#notes" hence, at the momement, there other changes should not be aggregated to a restricted journal.
Do not allow empty notes with restriction, as empty notes are not seen as comments
…ments-with-restricted-visibility Add new permissions for comments with restricted visibility
…estricted-comments-as-part-of-journal-notes
Co-authored-by: Kabiru Mwenja <k.mwenja@openproject.com>
Further adopt the notion of restricted journals. Co-authored-by: Bruno Pagno <b.pagno@openproject.com>
…estricted-comments-as-part-of-journal-notes
…omments-with-restricted-visibility' into implementation/60980-introduce-work-package-restricted-comments-as-part-of-journal-notes
…comments-as-part-of-journal-notes' into impl/60989-hide-restricted-comments
Reject restricted journals when user cannot see them
…ture-flag Feature flag for comments with restricted visibility
rename permission to add_comments_with_restricted_visibility
The color hex codes are bound to change as we should default to primer colors that work in all color modes
Design [OPEN POINT](https://community.openproject.org/wp/61949)
1.) Use primer default (form) layout 2.) Better for a11ly as there's no dissapearing and reappearing text 3.) Consistent on mobile layouts as no wrapping is done on smaller widths
AR association extensions ensure the `restricted_visible` scope is only visible on the work package journals association. #18091 (comment)
…ions-for-safety implementation/60980 - Define restricted extension on work package journals for query safety
Improve fetcher query
…ntroduce-work-package-restricted-comments-as-part-of-journal-notes
Bumps [codemirror](https://github.com/codemirror/basic-setup) from 5.65.18 to 5.65.19. - [Changelog](https://github.com/codemirror/basic-setup/blob/main/CHANGELOG.md) - [Commits](https://github.com/codemirror/basic-setup/commits) --- updated-dependencies: - dependency-name: codemirror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the aws-gems group with 1 update: [aws-sdk-core](https://github.com/aws/aws-sdk-ruby). Updates `aws-sdk-core` from 3.220.1 to 3.220.2 - [Release notes](https://github.com/aws/aws-sdk-ruby/releases) - [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-core/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-ruby/commits) --- updated-dependencies: - dependency-name: aws-sdk-core dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws-gems ... Signed-off-by: dependabot[bot] <support@github.com>
Quoting a restricted comment implicitly enables restriction if it did not exist before. When quoting both restricted and unrestricted comments within the same comment- the restricted state should stick
The old scope meant to determine if a user could "manage" custom fields. It was never about seeing them. Updated the scope names to reflect that.
…58f10fbb Bump aws-sdk-core from 3.220.1 to 3.220.2 in the aws-gems group
Update i18n config
…ev/codemirror-5.65.19 Bump codemirror from 5.65.18 to 5.65.19 in /frontend
…k-package-restricted-comments-as-part-of-journal-notes Introduce restricted journals for work package comments with restricted visibility
…stricting-custom-field-visibility-in-column-selection [#62317] redefine WorkPackageCustomField#visible_by_user scope
Make Git SCM interactions frozen string compatible
…-work-package-comments-with-restricted-visibility open-point/61949 primer colors for work package comments with restricted visibility
…g-criteria-for-work-package-comments-with-restricted-visibility implementation/60983 define quoting criteria for work package comments with restricted visibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )