Skip to content

feat: generate transitively-reduced spack graph svg and png#323

Merged
wdconinc merged 4 commits into
masterfrom
wdconinc-patch-14
Jul 1, 2026
Merged

feat: generate transitively-reduced spack graph svg and png#323
wdconinc merged 4 commits into
masterfrom
wdconinc-patch-14

Conversation

@wdconinc

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

We previously stopped spack package graph conversion to svg and png due to time needed to find a drawing solution. With tred we can do a transitive reduction of the graph, which is then tractable for drawing in seconds. So, now we generate a pretty picture.
env2

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Optimization (issue #__)
  • Updated documentation
  • other: __

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

Copilot AI review requested due to automatic review settings June 25, 2026 16:36
@wdconinc wdconinc enabled auto-merge (squash) June 25, 2026 16:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables generation of visual Spack environment dependency graphs during the containers/eic image build by producing a transitively-reduced DOT graph (via tred) and rendering it to SVG and PNG (via dot). This fits the repo’s goal of producing self-describing EIC container images by embedding build artifacts and environment metadata in the resulting image.

Changes:

  • Generate a transitively-reduced Spack dependency graph (env_tred.dot) from spack graph --dot output.
  • Render the reduced graph to /opt/spack-environment/env.svg and /opt/spack-environment/env.png during the image build.

Comment thread containers/eic/Dockerfile Outdated
Copilot AI review requested due to automatic review settings June 25, 2026 17:52

This comment was marked as resolved.

@wdconinc wdconinc requested review from a team and veprbl June 25, 2026 19:04
@wdconinc wdconinc changed the title feat: generated transitively-reduced spack graph svg and png feat: generate transitively-reduced spack graph svg and png Jun 26, 2026
@wdconinc wdconinc force-pushed the wdconinc-patch-14 branch from 3b1ada1 to 51ed75e Compare June 30, 2026 13:06
Copilot AI review requested due to automatic review settings June 30, 2026 13:06

This comment was marked as resolved.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 30, 2026 13:09

This comment was marked as duplicate.

@wdconinc wdconinc merged commit 941f7cf into master Jul 1, 2026
86 checks passed
@wdconinc wdconinc deleted the wdconinc-patch-14 branch July 2, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants