feat: npsim 1.8.0 - #378
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the EIC container Spack configuration to consume npsim v1.8.0 (per the referenced release) by tightening the package version constraint and aligning the pinned eic/eic-spack recipe revision to one that should contain the updated npsim package metadata.
Changes:
- Bump the required
npsimversion inspack-environment/packages.yamlfrom@1.7.0to@1.8.0. - Update the pinned
eic/eic-spackcommit ineic-spack.shto a newer revision.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spack-environment/packages.yaml | Updates the global Spack package constraint to require npsim@1.8.0. |
| eic-spack.sh | Advances the pinned eic/eic-spack commit to pick up the corresponding package recipe/version support. |
Member
Author
|
wdconinc
approved these changes
Aug 3, 2026
Contributor
Also already bumped to 4.7 GB in #376. |
wdconinc
force-pushed
the
pr/npsim_1_8_0
branch
from
August 4, 2026 02:35
368e1c6 to
2c6894b
Compare
Capybara summary for PR 378Last updated 2026-08-04T00:45-04:00 2c6894b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/eic/npsim/releases/tag/v1.8.0
Primary feature is that we'll be storing sensor-hitting optical photons in MCParticles (needed for IRT2).