Skip to content

feat: npsim 1.8.0 - #378

Merged
wdconinc merged 1 commit into
masterfrom
pr/npsim_1_8_0
Aug 4, 2026
Merged

feat: npsim 1.8.0#378
wdconinc merged 1 commit into
masterfrom
pr/npsim_1_8_0

Conversation

@veprbl

@veprbl veprbl commented Aug 3, 2026

Copy link
Copy Markdown
Member

https://github.com/eic/npsim/releases/tag/v1.8.0

Primary feature is that we'll be storing sensor-hitting optical photons in MCParticles (needed for IRT2).

Copilot AI review requested due to automatic review settings August 3, 2026 18:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the EIC container Spack configuration to consume npsim v1.8.0 (per the referenced release) by tightening the package version constraint and aligning the pinned eic/eic-spack recipe revision to one that should contain the updated npsim package metadata.

Changes:

  • Bump the required npsim version in spack-environment/packages.yaml from @1.7.0 to @1.8.0.
  • Update the pinned eic/eic-spack commit in eic-spack.sh to a newer revision.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
spack-environment/packages.yaml Updates the global Spack package constraint to require npsim@1.8.0.
eic-spack.sh Advances the pinned eic/eic-spack commit to pick up the corresponding package recipe/version support.

@veprbl

veprbl commented Aug 3, 2026

Copy link
Copy Markdown
Member Author
Checking compressed image size for ghcr.io/eic/eic_xl@sha256:c6750e93fc08b6c7ffa9dabc22cadb428d0b7bf9c754d9b79087408536d6c501 (limit: 4.6 GiB) ...
  Compressed size : 4.61 GiB (4939425560 bytes)
  Limit           : 4.6 GiB (4939212390 bytes)

ERROR: Image ghcr.io/eic/eic_xl@sha256:c6750e93fc08b6c7ffa9dabc22cadb428d0b7bf9c754d9b79087408536d6c501 exceeds the size cap!
       4.61 GiB > 4.6 GiB

To update the high-water mark after an intentional size increase:
  1. Re-run this script to inspect the published image size:
     scripts/check_image_size "ghcr.io/eic/eic_xl@sha256:c6750e93fc08b6c7ffa9dabc22cadb428d0b7bf9c754d9b79087408536d6c501" "4.6"
  2. Add ~15% buffer, and optionally round up to the next whole GiB
  3. Update SIZE_LIMIT_*_GIB in .github/workflows/build-push.yml and .gitlab-ci.yml

@wdconinc

wdconinc commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

ERROR: Image ghcr.io/eic/eic_xl@sha256:c6750e93fc08b6c7ffa9dabc22cadb428d0b7bf9c754d9b79087408536d6c501 exceeds the size cap!
4.61 GiB > 4.6 GiB

Also already bumped to 4.7 GB in #376.

Copilot AI review requested due to automatic review settings August 4, 2026 02:35
@wdconinc
wdconinc merged commit 3f21db6 into master Aug 4, 2026
6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Capybara summary for PR 378

Last updated 2026-08-04T00:45-04:00 2c6894b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants