Skip to content

hotfix: spack cherry-pick: acts: pass root variant to examples - #397

Merged
wdconinc merged 1 commit into
masterfrom
acts-examples-root
Aug 25, 2026
Merged

hotfix: spack cherry-pick: acts: pass root variant to examples#397
wdconinc merged 1 commit into
masterfrom
acts-examples-root

Conversation

@wdconinc

Copy link
Copy Markdown
Contributor

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

This PR ensures that also for Acts v46 we continue to build the ROOT bindings, which moved from plugins to the examples.

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

This is a dependency of the material validation pipeline in the epic repo.

What kind of change does this PR introduce?

Please check if any of the following apply

  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

Copilot AI lite review requested due to automatic review settings August 23, 2026 18:51
@wdconinc wdconinc changed the title fix: spack cherry-pick: acts: pass root variant to examples hotfix: spack cherry-pick: acts: pass root variant to examples Aug 23, 2026

This comment was marked as low quality.

@wdconinc
wdconinc enabled auto-merge (squash) August 23, 2026 18:59
@github-actions

Copy link
Copy Markdown

Capybara summary for PR 397

@wdconinc

Copy link
Copy Markdown
Contributor Author

Not sure why this fails to address the issue...

  • Cherry pick of spack/spack-packages@ded706e is correctly adding example_cmake_variant("ROOT", "root"), to /opt/spack-packages/repos/spack_repo/builtin/packages/acts/package.py,
  • and jfro5sw acts@46.8.1 contains +examples and +root,
  • but /opt/software/linux-x86_64_v2/acts-46.8.1-jfro5swprshtq74fxbod2ywh2xwbw3gw/.spack/spack-configure-args.txt doesn't get a -DACTS_BUILD_EXAMPLES_ROOT=True argument.

Unfortunately .spack/spack-build-out.txt.gz is not saved correctly.

This in ghcr.io/eic/eic_ci:unstable-mr-397-nightly. Not sure what's wrong here.

@wdconinc

Copy link
Copy Markdown
Contributor Author

Ultimate test command, should pass python import of:

from acts.examples.root import RootMaterialTrackWriter

@wdconinc
wdconinc merged commit f679ee3 into master Aug 25, 2026
86 of 87 checks passed
@veprbl
veprbl deleted the acts-examples-root branch August 25, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants