Fix: xl drop dawn/dawncut - #407
Conversation
… maintainer comment; no dependents)
|
Yeah, but we still use dawn in github.com/eic/epic... |
|
The source is supposed to be found in the new eic-spack-mirror repository, and that works with my local spack but somehow not in the container build. Can you see why? That would be preferred. Other option is the project https://github.com/eic/dusk but that's not quite ready I fear. |
Digging into it. I will let you know. |
|
So, when I run diff --git a/containers/debian/Dockerfile b/containers/debian/Dockerfile
index 613f810e..eaafe8f2 100644
--- a/containers/debian/Dockerfile
+++ b/containers/debian/Dockerfile
@@ -358,6 +358,12 @@ git -C ${EICSPACK_ROOT} checkout ${EICSPACK_SHA:-${EICSPACK_VERSION}}
spack repo add --scope spack "${EICSPACK_ROOT}/spack_repo/eic"
EOF
+RUN --mount=type=cache,target=/var/cache/spack <<EOF
+set -e
+spack stage dawn
+spack stage dawncut
+EOF
+
## Workaround for Spack creating config files with limited permissions (see https://github.com/spack/spack/issues/52651)
RUN chmod 644 ${SPACK_ROOT}/etc/spack/*.yaml ${HOME}/.spack/*.yamlI get the following: which seems to indicate the staging pulls correctly from the eic-spack-mirror source mirror (ignore the other warnings... different mirrors). |
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR drops
dawnanddawncutfromxl/spack.yaml. No buildcache coverage and the URL source was broken. Look at this in https://github.com/eic/eic-spack/blob/develop/spack_repo/eic/packages/dawncut/package.pyThis fixes fetch and SSL errors on
build eic xl on *CI checks. Withdawnanddawncutboth removed fromxl/spack.yaml,eic_xlnow successfully concretized and built on amd64, amd64_v3, and arm64. Verified in #388. cc @wdconincWhat is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply