Remove unused files from copied common_bench code - #119
Merged
Conversation
The following files were copied from eic/common_bench but are not used in this repository: - bin/compile_analyses.py: Not called anywhere; ROOT compilation is handled by Snakemake's compile_analysis rule using ACLiC - bin/strict-mode.sh: Not referenced in any scripts or CI jobs - include/common_bench/particles.h: Not included by any analysis code; particle data is provided elsewhere as needed Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Verified there are no remaining in-repo references to the removed files and the Snakemake compilation flow does not depend on them.
Pull request overview
This PR removes three files that were previously copied from eic/common_bench and are not referenced by the current benchmark codebase or workflows, reducing maintenance surface and avoiding dead utilities/headers.
Changes:
- Deleted unused helper script
bin/compile_analyses.py. - Deleted unused bash boilerplate
bin/strict-mode.sh. - Deleted unused header
include/common_bench/particles.h.
File summaries
| File | Description |
|---|---|
| include/common_bench/particles.h | Removes an unused particle data header that is not included by any analysis code. |
| bin/strict-mode.sh | Removes an unused “strict bash mode” helper that is not sourced by repository scripts/workflows. |
| bin/compile_analyses.py | Removes an unused ROOT analysis compilation helper script (compilation handled via Snakemake instead). |
Review details
- Files reviewed: 1/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes three unused files that were copied from
eic/common_benchin a previous commit.Analysis
After a thorough code review:
Removed files:
bin/compile_analyses.py - Not referenced anywhere in the repository
compile_analysisrule using ACLiCbin/strict-mode.sh - Not referenced in any scripts or CI jobs
include/common_bench/particles.h - Not included by any analysis code
.cxxfiles include this headerFiles kept (as they are actively used):
bin/env.sh- Sets up environment and PATHbin/collect_benchmarks.py- Called in CI summary jobbin/collect_tests.py- Called in benchmark configsbin/mkdir_local_data_link- Called in CI setupinclude/common_bench/benchmark.h- Included by analysis codeinclude/common_bench/plot.h- Included by analysis codeinclude/common_bench/util.h- Included by analysis codeinclude/common_bench/exception.h- Included by benchmark.hVerification
Comprehensive search confirmed no references to removed files in CI/CD, Snakemake workflows, configurations, or code.