Remove unused variable JUGGLER_N_THREADS from bin/env.sh - #123
Merged
Conversation
Remove only the variable that is defined in env.sh but never used anywhere: JUGGLER_N_THREADS (line 65) - Exported from BENCHMARK_N_THREADS but never referenced in codebase - No external usage found (0 references across all file types) - Applications use ROOT_MAX_THREADS instead for thread configuration KEEP all other variables: BENCHMARK_* variables (BENCHMARK_N_EVENTS, BENCHMARK_N_THREADS, BENCHMARK_RNG_SEED): - Input configuration variables meant to be set by CI/server - Actively used within env.sh to create derived variables - Removing them breaks CI workflows ROOT_INCLUDE_PATH: - Used implicitly by ROOT at runtime for include path configuration - Not grep-detectable as it's read by compiled ROOT code - Keep per task requirements Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
wdconinc-remove-unused-env-vars
branch
from
September 3, 2026 21:51
686f1db to
7049ff9
Compare
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove only the environment variable that is defined in env.sh but never used anywhere in the codebase.
Changes
Removed 1 unused export:
JUGGLER_N_THREADS(line 65)BENCHMARK_N_THREADSbut never referenced anywhereROOT_MAX_THREADSinstead for thread configurationVariables Kept
All BENCHMARK_ variables* (input configuration for CI/server override):
BENCHMARK_N_EVENTS→ actively used to createJUGGLER_N_EVENTSBENCHMARK_N_THREADS→ actively used to createROOT_MAX_THREADSBENCHMARK_RNG_SEED→ actively used to createJUGGLER_RNG_SEEDROOT_INCLUDE_PATH (used implicitly by ROOT):
ROOT_MAX_THREADSwhich is used implicitly byROOT::EnableImplicitMT()Verification