Only notify confirmation subscribers on status change - #1189
Merged
Conversation
Previously the confirmation poll task sent the status into the watch channel on every poll, waking all subscribers (and emitting the "Monero transaction confirmation status update" log plus listener callbacks) even when nothing changed. Use send_if_modified so subscribers are only notified when the confirmation status actually changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XW4tknaCkMxw6p7ZnEXaH
Deploying eigenwallet-docs with
|
| Latest commit: |
1cd9e49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bdcb1a83.eigenwallet-docs.pages.dev |
| Branch Preview URL: | https://claude-monero-confirmation-p.eigenwallet-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the confirmation poll task sent the status into the watch
channel on every poll, waking all subscribers (and emitting the
"Monero transaction confirmation status update" log plus listener
callbacks) even when nothing changed. Use send_if_modified so
subscribers are only notified when the confirmation status actually
changes.