fix(sip_client): tokenize SDP m-line and answer with one codec - #288
Merged
Conversation
Replace substring payload-type matching (which false-positives on PT 96-99) with whitespace tokenization, generalize SdpInfo, and emit RFC 3264 answer SDP with only the chosen audio PT plus telephone-event. Reject offers with no common G.711 codec via 488. Add host-side parse_sdp tests and CI workflow. Refs #286 Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid CRLF breaking shebang execution of native test runners on Linux CI. Co-authored-by: Cursor <cursoragent@cursor.com>
ACK a 200 OK with no common codec then send BYE so the PBX does not keep the call. Parse only the first m=audio section (ignore video), skip non-numeric fmt tokens, and reject inbound INVITEs before mutating dialog state. Dynamic PT codec naming remains deferred to the Codec refactor. Refs #286 Co-authored-by: Cursor <cursoragent@cursor.com>
Restore RFC 4566 <port>/<number of ports> parsing (atoi stops at '/') and stop clearing d_local_tag_ after a 488 so OPTIONS replies cannot emit an empty ;tag=. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.