feat: replace pipeline-based reads and writes with buffer operations - #649
Merged
Conversation
writeJSON and readJSON now use sink.writeBuffer() and sink.readBuffer() respectively, eliminating all pipeline() and stream infrastructure from metadata writes and reads. _persistFile buffers tar entry chunks with for-await and uses sink.writeBuffer(), replacing pipeline(entry, integrityStream, writer). ssri.fromData() replaces the integrityStream Transform. The drainPending concurrency limit is preserved for backpressure on tar extraction.
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
# [2.4.0](v2.3.0...v2.4.0) (2026-08-25) ### Features * replace pipeline-based reads and writes with buffer operations ([#649](#649)) ([ace642f](ace642f))
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates pipeline() calls from the upload and metadata read/write path:
ssri.fromData() computes the integrity hash directly from the Buffer.
The drainPending concurrency limit (MAX_CONCURRENT_WRITES) is preserved to maintain backpressure on tar extraction. Only pipeline(busboy, tarParser) remains, which is safe as both streams are fresh per-request.
Also adds writeBuffer() and readBuffer() to the internal SinkTest class used in core's test suite.