Skip to content

Fix Hermes imported history and native tool activity rendering#4

Merged
eimexdev merged 10 commits into
mainfrom
t3code/fix-imported-chat-formatting
Jul 24, 2026
Merged

Fix Hermes imported history and native tool activity rendering#4
eimexdev merged 10 commits into
mainfrom
t3code/fix-imported-chat-formatting

Conversation

@eimexdev

Copy link
Copy Markdown
Owner

Summary

  • Normalize and refresh imported Hermes timelines while preserving source order, turn IDs, timestamps, and history slots.
  • Render live and imported Hermes tool calls as native activities with correlated lifecycle events and full tool metadata.
  • Remove Hermes-specific title synchronization in favor of standard thread-title generation and projection behavior.
  • Add focused coverage for imports, refresh replacement, tool callbacks, activity payloads, and timeline projection.

Testing

  • Added and updated focused unit tests across Hermes adapter, bridge client, conversation lifecycle, orchestration, projection, runtime ingestion, and client state.
  • Not run locally.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@eimexdev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a6c7fb61-d27e-4ee7-9b78-4f4e2075d0ab

📥 Commits

Reviewing files that changed from the base of the PR and between 81aab94 and c79b254.

📒 Files selected for processing (30)
  • apps/server/src/orchestration/Layers/ProjectionPipeline.test.ts
  • apps/server/src/orchestration/Layers/ProjectionPipeline.ts
  • apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.test.ts
  • apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts
  • apps/server/src/orchestration/decider.import.test.ts
  • apps/server/src/orchestration/decider.ts
  • apps/server/src/orchestration/projector.ts
  • apps/server/src/provider/Layers/HermesAdapter.test.ts
  • apps/server/src/provider/Layers/HermesAdapter.ts
  • apps/server/src/provider/hermes/HermesBridgeClient.test.ts
  • apps/server/src/provider/hermes/HermesConversationLifecycle.test.ts
  • apps/server/src/provider/hermes/HermesConversationLifecycle.ts
  • apps/web/src/components/chat/MessagesTimeline.test.tsx
  • apps/web/src/components/chat/MessagesTimeline.tsx
  • apps/web/src/components/hermes/HermesSessionBrowser.logic.test.ts
  • apps/web/src/components/hermes/HermesSessionBrowser.logic.ts
  • apps/web/src/hermesLineage.ts
  • apps/web/src/session-logic.test.ts
  • apps/web/src/session-logic.ts
  • integrations/hermes/t3agent/README.md
  • integrations/hermes/t3agent/adapter.py
  • integrations/hermes/t3agent/tests/test_adapter.py
  • packages/client-runtime/package.json
  • packages/client-runtime/src/state/entities.test.ts
  • packages/client-runtime/src/state/hermesImportedHistory.test.ts
  • packages/client-runtime/src/state/hermesImportedHistory.ts
  • packages/client-runtime/src/state/threadDetail.ts
  • packages/contracts/src/hermesBridge.test.ts
  • packages/contracts/src/hermesBridge.ts
  • packages/contracts/src/orchestration.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/fix-imported-chat-formatting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jul 24, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73bbd72d34

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +217 to +222
const childSessionId = HermesBridgeSessionId.make(`t3-${existingThreadId}`);
const refreshRequestId = HermesBridgeRequestId.make(
`conversation-refresh:${source.sessionId}:${existingThreadId}:${yield* dependencies.randomUuid}`,
);
const fork = yield* client
.forkSession({

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Refresh the Hermes child session before reusing it

When an existing external import is opened after the source Hermes session has received more messages, this refresh path reuses t3-${existingThreadId}. The t3agent adapter's /v1/sessions/fork handler only calls db.replace_messages inside if not child_exists, so the response refreshes the T3 projection but the bound Hermes child session that future prompts run against still contains the old copied messages. Please update the existing matching child session's stored messages during refresh, or create a new child session, before opening it.

Useful? React with 👍 / 👎.

…hat-formatting

# Conflicts:
#	apps/server/src/provider/hermes/HermesConversationLifecycle.ts
@eimexdev
eimexdev merged commit dadeaf8 into main Jul 24, 2026
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant