Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Maven example Makefile so make clean can run even when Maven isn’t installed.
Changes:
- Alters the
cleantarget to ignore failures frommvn -q clean.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| clean: | ||
| mvn -q clean | ||
| -mvn -q clean |
There was a problem hiding this comment.
Prefixing the Maven command with - makes make clean ignore all mvn clean failures (including real build/cleanup errors), not just the 'mvn not found' case. A more robust approach is to conditionally run Maven only if it exists on PATH (e.g., command -v mvn ... guarded mvn -q clean), so legitimate Maven failures still surface while still allowing cleaning without Maven.
Suggested change
| -mvn -q clean | |
| command -v mvn >/dev/null 2>&1 && mvn -q clean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.