Fix memory leak #13
Merged
Fix memory leak #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 13, 2015 12:22
When code like:
intervalTree a; //Fill a
intervalTree b; //Fill b
b=a;
was executed, b's contents would not get deleted before being
overwritten by a copy of a's contents. Though I could have fixed the
bug directly, I fixed that class of bugs by making left and right
unique_ptr. Changing to unique_ptr also simplified the code allowing
the destructor to be defaulted and the assignment code for left and
right to be reduced to two assignments. (If we were using C++ 14 the
copyTree helper function could have been omitted too since it has
make_unique.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a memory leak by moving to unique_ptr and also moved the initialization in the constructors to their initialization lists.
I considered having conditional compilation for C++98 to use auto_ptr, but the makefile specifies C++0x so I decided against it.