Skip to content

Conversation

@jialeicui
Copy link
Contributor

In function ' intervalStart ' & ' intervalStop ', the return value type may be typename K
and change the default value type to std::size_t, so I can use larger value by default

@jialeicui
Copy link
Contributor Author

I'm writing a small program: load some ip ranges cover IPv4, input an ip address and return the range index.
So I thought std::size_t work well with common integer data types.
I changed the default value type, it's an easy way to change the default value type by defining inter_type

@ekg
Copy link
Owner

ekg commented Apr 2, 2015

In the interest of minimizing the namespace of the library, let's just use
size_t here. There are only two places it's used. Would you please update
the patch? Sorry for the trouble.
On Apr 2, 2015 9:16 AM, "Jialei" notifications@github.com wrote:

I'm writing a small program: load some ip ranges cover IPv4, input an
ip address and return the range index.
So I thought std::size_t work well with common integer data types.
I changed the default value type, it's an easy way to change the default
value type by defining inter_type


Reply to this email directly or view it on GitHub
#9 (comment).

@jialeicui
Copy link
Contributor Author

😄
like this?

@ekg
Copy link
Owner

ekg commented Apr 2, 2015

Absolutely :)

Thanks!

ekg added a commit that referenced this pull request Apr 2, 2015
return value type fix & change default value type
@ekg ekg merged commit 399f63c into ekg:master Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants