Vice 2.7.2

Mostly about failures that were happening quietly. Four of these are cases
where Vice knew something had gone wrong and did not tell anyone.

Clips that save but will not play (#154)

If a clip came out unreadable, Vice logged that it could not parse some JSON
and threw away the actual reason ffprobe gave. That was my fault and it is
why this one has taken three rounds with the reporter without getting solved.
ffprobe's own message is kept and logged now, so one line from the log should
be enough to tell what is wrong with the file.

Three other things around the same bug:

• The clip-saved sound played before the save finished, so a failed save
  still sounded like it worked. There is a separate failure tone now. The
  saved tone stays where it was, because flushing a long buffer takes seconds
  and waiting in silence would be worse.
• The error message said "check vice.log" instead of what actually happened.
  It now names the file and the reason.
• A clip that could not be read was listed in the gallery as an ordinary clip
  of 0:00 with no thumbnail, which is exactly what a broken clip looks like
  from the outside. It is marked as unreadable now, with the reason. The file
  is never touched.

Recording carrying on after the daemon is gone (#121)

The recorder runs in its own session so its helper process gets cleaned up
with it. The side effect was that killing the daemon outright, or the daemon
crashing, left gpu-screen-recorder running with nothing supervising it, and
starting Vice again put a second one next to it. I found one on my own
machine that had been holding 727 MB and the GPU encoder for ten hours.

Vice now writes down each recorder it starts and clears any survivor when it
starts up. It only ever stops one when the command line still matches what it
recorded, the daemon that owned it is gone, and the process leads its own
group, because killing something unrelated would be much worse than the
leftover.

One window (#121)

Opening Vice again gave you a second window onto the same daemon, and the two
disagreed about settings. It raises the window you already have instead.

Settings quietly changing what you record

Two of them:

• If your saved display was not in the list gpu-screen-recorder returned,
  Settings reset the picker to Auto and the next save wrote it away for good.
  Setting the display by hand is the only way to reach a monitor that will not
  enumerate, so opening Settings once undid the only workaround there is.
  It is kept now.
• With separate audio tracks set up and "capture desktop audio" turned off,
  the recorder keeps only microphone sources, so a game track disappears and
  you get just your voice. Settings now tells you which tracks will be
  dropped instead of letting it happen quietly. This is very likely what #137
  is.

Smaller things

• Custom notification sounds. Point Settings at your own file for any of the
  five events. Anything missing or unreadable falls back to the built-in tone,
  so a typo cannot leave you with silence.
• GeoGuessr Steam Edition is detected now, thanks to @editeurlaruelle-cmd.
• The test suite runs on every push and pull request.
• Em-dashes are gone from everything, including the package description and
  the desktop entry, and there is a test so they stay gone.

Upgrading

yay -Syu vice-clipper
systemctl --user restart vice.service