-
Notifications
You must be signed in to change notification settings - Fork 327
Try to fix flaky VertxServerTest #2361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix flaky VertxServerTest #2361
Conversation
|
👋 @tobiasstadler Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
@eyalkoren Would you mind running the tests again? |
|
@tobiasstadler it looks good, I believe this failure is related to #2354 @Mergifyio update |
✅ Branch has been successfully updated |
|
@eyalkoren Would you please run the /test and run elasticsearch-ci/docs |
|
/test |
|
run elasticsearch-ci/docs |
|
Thank You! |
😢 |
|
@Mergifyio update /test |
✅ Branch has been successfully updated |
|
/test |
|
It finally passed the tests. Would you please merge it? |
jackshirazi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Thank You! |
What does this PR do?
Try to fix VertxServerTest by letting VertX choose a random port
Checklist