skip flaky test in aioredis #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for the flakines is as of yet unknown. It looks like the `execute_pubsub` method sometimes isn't instrumented, which might point towards an import-time instrumentation-race. A new version of aioredis will be released soon with completely rewritten internals. The hope is that this issue will go away at that point. Using `pytest.mark.flaky` isn't an option, as `flaky` doesn't support async tests.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
The reason for the flakines is as of yet unknown. It looks like the `execute_pubsub` method sometimes isn't instrumented, which might point towards an import-time instrumentation-race. A new version of aioredis will be released soon with completely rewritten internals. The hope is that this issue will go away at that point. Using `pytest.mark.flaky` isn't an option, as `flaky` doesn't support async tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for the flakines is as of yet unknown. It looks like the
execute_pubsubmethodsometimes isn't instrumented, which might point towards an import-time instrumentation-race.
A new version of aioredis will be released soon with completely rewritten internals.
The hope is that this issue will go away at that point.
Using
pytest.mark.flakyisn't an option, asflakydoesn't support async tests.