Skip to content

skip flaky test in aioredis #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2021
Merged

skip flaky test in aioredis #1143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/instrumentation/asyncio_tests/aioredis_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,15 @@ async def test_redis_client(instrument, elasticapm_client, redis_conn):
assert len(spans) == 3


@pytest.mark.skip(reason="Test is flaky for some reason, possibly related to import-time instrumentation")
@pytest.mark.integrationtest
async def test_publish_subscribe(instrument, elasticapm_client, redis_conn):
async def test_publish_subscribe_async(instrument, elasticapm_client, redis_conn):
elasticapm_client.begin_transaction("transaction.test")
with capture_span("test_publish_subscribe", "test"):
# publish
await redis_conn.publish("mykey", "a")

#subscribe
# subscribe
await redis_conn.subscribe("mykey")

elasticapm_client.end_transaction("MyView")
Expand Down