filebeat/filestream: Use gzip.Reader.Reset instead of Close+NewReader#48516
Merged
orestisfl merged 1 commit intoelastic:mainfrom Jan 23, 2026
Merged
Conversation
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
🤖 GitHub commentsJust comment with:
|
|
This pull request doesn't have a |
Replace the pattern of closing the gzip reader and creating a new one with a call to gzip.Reader.Reset() in gzipSeekerReader.Seek(). `Reset()` is the idiomatic way to reuse a gzip reader when switching to a new underlying reader. It: - Reuses internal buffers instead of allocating new ones, reducing memory pressure and GC overhead - Is semantically equivalent to creating a new reader (discards current state and reinitializes) - Eliminates the unnecessary `Close()` call whose error was being ignored anyway
d0899c2 to
078f098
Compare
AndersonQ
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
filebeat/filestream: Use gzip.Reader.Reset instead of Close+NewReader
Replace the pattern of closing the gzip reader and creating a new one with a call to gzip.Reader.Reset() in gzipSeekerReader.Seek().
Reset()is the idiomatic way to reuse a gzip reader when switching to a new underlying reader. It:Close()call whose error was being ignored anywayChecklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesstresstest.shscript to run them under stress conditions and race detector to verify their stability.I have added an entry in./changelog/fragmentsusing the changelog tool.How to test this PR locally
Run the gzip-related unit and integration tests
Related issues
opensyscalls.