merge queue: embarking main (a7d1166) and #4368 together#4812
Closed
mergify[bot] wants to merge 5 commits into
Closed
merge queue: embarking main (a7d1166) and #4368 together#4812mergify[bot] wants to merge 5 commits into
mergify[bot] wants to merge 5 commits into
Conversation
- Replace deprecated NewSimpleClientset with NewClientset in all test files - Add setup_test.go with noWatchListGates to disable WatchListClient feature gate in k8s fetcher and dataprovider test packages; k8s v0.35+ enables this gate by default but the fake client hangs indefinitely without it disabled Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fake.NewClientset() (k8s v0.35+) parses a ~382KB YAML schema on first call via sync.Once, taking >100ms. This exceeds the pre-commit go-test timeout. Pre-warm it in TestMain so the cost doesn't count against the per-test clock. Also replace remaining NewSimpleClientset (deprecated SA1019) with NewClientset in kube_fetcher_test.go and elb_fetcher_test.go. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull request #4368 has been dequeued. ✨
The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. Changes must be made through the merge queue
Branch main (a7d1166) and #4368 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #4368.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:#approved-reviews-by >= 1[🛡 GitHub branch protection]#approved-reviews-by >= 1[🛡 GitHub repository ruleset rule[org] Require a PR for Renovate]#approved-reviews-by >= 1[🛡 GitHub repository ruleset rule[org] Require a PR]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset rule[org] Require a PR for Renovate]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset rule[org] Require a PR]check-success=Lintcheck-success=Manifest Testscheck-success=Package Cloudbeat (docker)check-success=Package Cloudbeat (tar.gz)check-success=Test Rego Policiescheck-success=Unit Testcheck-success = CLAcheck-neutral = CLAcheck-skipped = CLAcheck-success = Package Cloudbeat (docker)check-neutral = Package Cloudbeat (docker)check-skipped = Package Cloudbeat (docker)check-success = Package Cloudbeat (tar.gz)check-neutral = Package Cloudbeat (tar.gz)check-skipped = Package Cloudbeat (tar.gz)check-success = Manifest Testscheck-neutral = Manifest Testscheck-skipped = Manifest Testscheck-success = Test Rego Policiescheck-neutral = Test Rego Policiescheck-skipped = Test Rego Policiescheck-success = Lintcheck-neutral = Lintcheck-skipped = Lintcheck-success = Unit Testcheck-neutral = Unit Testcheck-skipped = Unit TestRequired conditions to stay in the queue:
#approved-reviews-by >= 1[🛡 GitHub branch protection]#approved-reviews-by >= 1[🛡 GitHub repository ruleset rule[org] Require a PR for Renovate]#approved-reviews-by >= 1[🛡 GitHub repository ruleset rule[org] Require a PR]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset rule[org] Require a PR for Renovate]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset rule[org] Require a PR]check-success = CLAcheck-neutral = CLAcheck-skipped = CLAcheck-success = Package Cloudbeat (docker)check-neutral = Package Cloudbeat (docker)check-skipped = Package Cloudbeat (docker)check-success = Package Cloudbeat (tar.gz)check-neutral = Package Cloudbeat (tar.gz)check-skipped = Package Cloudbeat (tar.gz)check-success = Manifest Testscheck-neutral = Manifest Testscheck-skipped = Manifest Testscheck-success = Test Rego Policiescheck-neutral = Test Rego Policiescheck-skipped = Test Rego Policiescheck-success = Lintcheck-neutral = Lintcheck-skipped = Lintcheck-success = Unit Testcheck-neutral = Unit Testcheck-skipped = Unit Test