[ServiceNow] Paginate API calls when we have advanced sync rules - #3559
Merged
Conversation
lorenabalan
marked this pull request as ready for review
July 29, 2025 13:31
lorenabalan
changed the title
meghanmurphy1
previously approved these changes
Jul 29, 2025
meghanmurphy1
left a comment
meghanmurphy1
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I think we just need to add backport labels to 8.17, 8.18, 9.0, and 9.1 😵💫
artem-shelkovnikov
approved these changes
Jul 30, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3509
get_filter_apis()with appropriate offset instead of 0, similarly to how we do it inget_record_apis()asyncbecause of the call toget_table_lengthTested it locally and we get more than 50 documents upserted, as per screenshot below:
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)Release Note