[Tweak] Use global constants to speed up tests #2629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokensound77
requested review from
Mikaayenson and
terrancedejesus
as code owners
Mikaayenson
approved these changes
Mar 8, 2023
terrancedejesus
approved these changes
Mar 8, 2023
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit 0010281)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit 0010281)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit 0010281)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit 0010281)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit 0010281)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit 0010281)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit 0010281)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit 0010281)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: brokensound77 <brokensound77@users.noreply.github.com> (cherry picked from commit 0010281)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
related to #2626
Summary
Rolls back to initial commit in #2626. Uses global constants to hold flags rather than using class variables. This is necessary because of how
SetUpClassis called and because each newTestCasereloads the base class