Skip to content

[Tweak] Use global constants to speed up tests #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[Tweak] Use global constants to speed up tests #2629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions tests/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
from detection_rules.rule_loader import DeprecatedCollection, DeprecatedRule, RuleCollection, production_filter


RULE_LOADER_FAIL = False
RULE_LOADER_FAIL_MSG = None
RULE_LOADER_FAIL_RAISED = False


@lru_cache
def default_rules() -> RuleCollection:
return RuleCollection.default()
Expand All @@ -27,32 +32,36 @@ class BaseRuleTest(unittest.TestCase):

@classmethod
def setUpClass(cls):
global RULE_LOADER_FAIL, RULE_LOADER_FAIL_MSG

# too noisy; refactor
# os.environ["DR_NOTIFY_INTEGRATION_UPDATE_AVAILABLE"] = "1"

if not cls.RULE_LOADER_FAIL:
if not RULE_LOADER_FAIL:
try:
rc = default_rules()
cls.all_rules = rc.rules
cls.rule_lookup = rc.id_map
cls.production_rules = rc.filter(production_filter)
cls.deprecated_rules: DeprecatedCollection = rc.deprecated
except Exception as e:
cls.RULE_LOADER_FAIL = True
cls.RULE_LOADER_FAIL_MSG = str(e)
RULE_LOADER_FAIL = True
RULE_LOADER_FAIL_MSG = str(e)

@staticmethod
def rule_str(rule: Union[DeprecatedRule, TOMLRule], trailer=' ->') -> str:
return f'{rule.id} - {rule.name}{trailer or ""}'

def setUp(self) -> None:
if self.RULE_LOADER_FAIL:
global RULE_LOADER_FAIL, RULE_LOADER_FAIL_MSG, RULE_LOADER_FAIL_RAISED

if RULE_LOADER_FAIL:
# limit the loader failure to just one run
# raise a dedicated test failure for the loader
if not self.RULE_LOADER_FAIL_RAISED:
self.RULE_LOADER_FAIL_RAISED = True
if not RULE_LOADER_FAIL_RAISED:
RULE_LOADER_FAIL_RAISED = True
with self.subTest('Test that the rule loader loaded with no validation or other failures.'):
self.fail(f'Rule loader failure: \n{self.RULE_LOADER_FAIL_MSG}')
self.fail(f'Rule loader failure: \n{RULE_LOADER_FAIL_MSG}')

self.skipTest('Rule loader failure')
else:
Expand Down