-
Notifications
You must be signed in to change notification settings - Fork 603
[Rule Tuning] Tune Threat Indicator Match Rules #2957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could we consider changing the URL Indicator rule to use both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [Rule Tuning] Tune Threat Indicator Match Rules * Update threat_intel_indicator_match_url.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 0ff50ac)
* [Rule Tuning] Tune Threat Indicator Match Rules * Update threat_intel_indicator_match_url.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 0ff50ac)
* [Rule Tuning] Tune Threat Indicator Match Rules * Update threat_intel_indicator_match_url.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 0ff50ac)
* [Rule Tuning] Tune Threat Indicator Match Rules * Update threat_intel_indicator_match_url.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 0ff50ac)
* [Rule Tuning] Tune Threat Indicator Match Rules * Update threat_intel_indicator_match_url.toml --------- Co-authored-by: Colson Wilhoit <48036388+DefSecSentinel@users.noreply.github.com> (cherry picked from commit 0ff50ac)
Issues
Resolves #2954
Summary
domain
fields on this rule, as it is more noisy than expected, as a lot of commonly used web services are included in threat intel fields. Such as Github, dropbox, discord, google drive, etc.dll.pe.imphash
, as integrations such as abusech contain events with this field empty, which can match the target field in specific conditions in which it is not populated by Elastic Endpoint, generating thousands of unintended matches:Some other approaches considered:
I've looked at using QueryDSL as a filter in the Indicator index query but excluding indicators that don't populate certain fields will cause the other fields which contain the information to be excluded, causing FNs.
Other potential solutions to the problem:
As this matches a specific condition on the endpoint, we could add a filter that excludes the events which cause this, here is a working query that we could ship as a filter:
Query