Skip to content

Fix CopyBrandingResources failure during serve in-memory build#3718

Merged
Mpdreamz merged 3 commits into
mainfrom
fix/branding-serve
Jul 24, 2026
Merged

Fix CopyBrandingResources failure during serve in-memory build#3718
Mpdreamz merged 3 commits into
mainfrom
fix/branding-serve

Conversation

@Mpdreamz

@Mpdreamz Mpdreamz commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Why

Two issues with branding in isolated builds:

  1. When a docset has branding: icon: configured, docs-builder serve throws a DirectoryNotFoundException during the in-memory validation build. The serve command uses separate read (real disk) and write (in-memory) filesystems, but CopyBrandingResources called source.CopyTo() which operates within the read filesystem — targeting a _static directory that only exists on the write side.

  2. Non-elastic orgs using docs-builder see the Elastic logo in the isolated header by default, which is incorrect for white-label use.

What

  • Replaced source.CopyTo() in CopyBrandingResources with a filesystem-aware copy that follows the same pattern as DocumentationFileExporterBase.CopyFileFsAware: when read and write filesystems differ, bytes are read from the source and written via the write filesystem. Added a regression test.

  • The isolated header now checks the git remote org and only renders the Elastic EuiHeaderLogo when the org is elastic. Non-elastic repos get a plain title link with no logo.

@Mpdreamz @claude @cursoragent
Fix CopyBrandingResources failure during serve in-memory build
7d272db 
source.CopyTo() operates within the read filesystem, which fails when
the write filesystem is a separate in-memory MockFileSystem (serve path)
because _static only exists on the write side. Use the same cross-FS
copy pattern as DocumentationFileExporterBase.CopyFileFsAware.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Mpdreamz Mpdreamz added the bug label Jul 24, 2026
@Mpdreamz
Mpdreamz requested a review from a team as a code owner July 24, 2026 07:41
@Mpdreamz
Mpdreamz requested a review from cotti July 24, 2026 07:41
Mpdreamz and others added 2 commits July 24, 2026 09:59
@Mpdreamz @claude @cursoragent
Show Elastic logo in isolated header only when git org is elastic
8784459 
Non-elastic orgs using docs-builder should not see the Elastic logo by
default. The isolated header now checks the git remote org and renders
a plain title link for non-elastic repos.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Mpdreamz @claude @cursoragent
Render logo as plain span when logoHref is not set
81d742a 
Make logoHref optional and fall back to a non-clickable <span> in all
header variants when no href is provided, instead of rendering an <a>
with an empty or undefined href.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Mpdreamz
Mpdreamz merged commit ad09bc3 into main Jul 24, 2026
24 checks passed
@Mpdreamz
Mpdreamz deleted the fix/branding-serve branch July 24, 2026 08:18
Mpdreamz added a commit that referenced this pull request Jul 24, 2026
@Mpdreamz @claude @cursoragent
Fix CopyBrandingResources failure during serve in-memory build (#3718)
b4a97bd 
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Mpdreamz added a commit that referenced this pull request Jul 24, 2026
@Mpdreamz @claude
@cursoragent @reakaleek
Replace pagefind native binary with Pagefind.Net managed library (#3721)
4554e3a 
* Emit Mermaid diagrams as external SVG files loaded via img (#3713)

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Fix CopyBrandingResources failure during serve in-memory build (#3718)

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix overlapping scope roots for nested Codex config paths (#3719)

docs-builder 1.29.0 added extension roots from FindGitRoot for Codex
commands. When config.yml lives under environments/internal/, the resolved
root is nested inside WorkingDirectoryRoot and ScopedFileSystem rejects
the overlapping roots. Normalize extension roots before constructing the
scoped filesystem so redundant nested paths are dropped.

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify scope root normalization for nested extension roots (#3720)

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* Replace pagefind native binary with Pagefind.Net managed library

Replace PR #3709's native pagefind binary subprocess approach with the
Pagefind.Net and Pagefind.Net.Frontend NuGet packages — pure managed
.NET, no native binary, AOT-compatible.

The pagefind indexer is now a proper IMarkdownExporter that eagerly
indexes each page during ExportAsync (O(1) memory) and flushes the
index to disk in FinishExportAsync. It is included in both
ExportOptions.Default and ExportOptions.Validation, so it works in
isolated builds and docs-builder serve mode automatically.

Key changes:
- New PagefindMarkdownExporter in Elastic.Markdown/Exporters/Pagefind
- New Exporter.Pagefind enum value, registered in both ExporterParsers
- Removed native binary pipeline (package-pagefind.mjs, embedded
  resource, pagefind npm dep, PagefindSearchIndexer subprocess)
- Removed static-search feature flag — search is always available
  for isolated builds and serve mode
- Serve mode reads pagefind files from the background build's
  in-memory filesystem via a route handler
- Added .pagefind-net-frontend-version to AllowedHiddenFileNames

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Jan Calanog <jan.calanog@elastic.co>
Mpdreamz added a commit that referenced this pull request Jul 25, 2026
@Mpdreamz @claude
@cursoragent @reakaleek
Replace pagefind native binary with Pagefind.Net managed library (#3721)
5264e09 
* Emit Mermaid diagrams as external SVG files loaded via img (#3713)

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Fix CopyBrandingResources failure during serve in-memory build (#3718)

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix overlapping scope roots for nested Codex config paths (#3719)

docs-builder 1.29.0 added extension roots from FindGitRoot for Codex
commands. When config.yml lives under environments/internal/, the resolved
root is nested inside WorkingDirectoryRoot and ScopedFileSystem rejects
the overlapping roots. Normalize extension roots before constructing the
scoped filesystem so redundant nested paths are dropped.

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* Simplify scope root normalization for nested extension roots (#3720)

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* Replace pagefind native binary with Pagefind.Net managed library

Replace PR #3709's native pagefind binary subprocess approach with the
Pagefind.Net and Pagefind.Net.Frontend NuGet packages — pure managed
.NET, no native binary, AOT-compatible.

The pagefind indexer is now a proper IMarkdownExporter that eagerly
indexes each page during ExportAsync (O(1) memory) and flushes the
index to disk in FinishExportAsync. It is included in both
ExportOptions.Default and ExportOptions.Validation, so it works in
isolated builds and docs-builder serve mode automatically.

Key changes:
- New PagefindMarkdownExporter in Elastic.Markdown/Exporters/Pagefind
- New Exporter.Pagefind enum value, registered in both ExporterParsers
- Removed native binary pipeline (package-pagefind.mjs, embedded
  resource, pagefind npm dep, PagefindSearchIndexer subprocess)
- Removed static-search feature flag — search is always available
  for isolated builds and serve mode
- Serve mode reads pagefind files from the background build's
  in-memory filesystem via a route handler
- Added .pagefind-net-frontend-version to AllowedHiddenFileNames

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Jan Calanog <jan.calanog@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reakaleek reakaleek reakaleek approved these changes
@cotti cotti Awaiting requested review from cotti cotti is a code owner automatically assigned from elastic/docs-engineering

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mpdreamz @reakaleek