Navigation: drop ViewModel, use Leaf/Node + RootIndex - #3784
Merged
Conversation
Remove NavigationViewModel so writers project straight into NavigationRenderModel, and lift the synthetic root-index row out of the tree as RootIndex. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
reakaleek
approved these changes
Aug 6, 2026
NotBeNull() does not expose Subject; assert the URL on the property directly. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Mpdreamz
added a commit
that referenced
this pull request
Aug 6, 2026
…odel Resolve conflicts after PR #3784 (Navigation: drop ViewModel, use Leaf/Node + RootIndex). The new rendering pipeline projects raw nav items into NavigationRenderNode records before templates see them. Island listing nodes need a matching projection: - Add IsIslandListing bool to NavigationRenderNode (hashed in ContentHash) - NavigationRenderModel.CreateNode: detect IsIslandListing; set ShowToggle=false and NavigationItems=[] so the toggle and subtree are suppressed in the main nav - _TocTreeNav.cshtml: for IsIslandListing nodes render a link chevron (<a href>) instead of the expand/collapse label; guard subtree on NavigationItems.Count > 0 - IsolatedBuildNavigationHtmlWriter / GlobalNavigationHtmlWriter: use separate ConcurrentDictionary<string,string> for island HTML (NavigationRenderCache is keyed by IRootNavigationItem object reference, not by string id) - GlobalNavigationHtmlWriter: drop IDisposable + Dispose() (semaphore removed in #3784) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #3750 introduced both
NavigationViewModelandNavigationRenderModel, which both read as Razor bind targets. After the projection, onlyNavigationRenderModelis the template model — the extra type adds an unnecessary hop and keeps presentational chrome (IndexLink) mixed into the tree kinds.What
NavigationViewModel; writers and tests callNavigationRenderModel.Create(...)directlyLeaf/Nodeto match domain vocabularyNavigationRenderModel.RootIndexRootIndexin the content hash (navigation-tree-v2)Opened against #3750 so we can discuss the shape on the feature branch.
Made with Cursor