Add APM to shared versioning

[bmorelli25]

• Allows APM Server to take advantage of the new shared version file by adding apm_server_version
• Allows us to finally stop linking to current versions of all APM Agent documentation 🎉
  • Moves APM Agent version attributes to the shared version files.
  • Moves APM Agent attributes from the APM Server version file to the shared attributes file

[bmorelli25]

I'm going to try deprecating the -v links instead. If this ci build is too ugly I might go back to the original option... we'll see 🤞

[bmorelli25]

Well that's cool. Updating the ref links from current to versioned didn't break anything! Can I get an Amen! LGTM?

[nik9000]

LGTM but for a little extra paranoia lets rebuild everything and make sure nothin weird happened.

@elasticmachine, run elasticsearch-docs/doc rebuild

[nik9000]

@elasticmachine, run elasticsearch-docs/doc rebuild

[nik9000]

@elasticmachine, run elasticsearch-ci/docs rebuild

[nik9000]

I noticed these in the last run, actually:

06:00:42 INFO:build_docs:Bad cross-document links:
06:00:42 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elastic-stack/7.3/apm-highlights.html:
06:00:42 INFO:build_docs:   - en/apm/agent/dotnet/{apm-dotnet-branch}/public-api.html
06:00:42 INFO:build_docs:   - en/apm/agent/rum-js/{apm-rum-branch}/react-integration.html
06:00:42 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elastic-stack/current/apm-highlights.html:
06:00:42 INFO:build_docs:   - en/apm/agent/dotnet/{apm-dotnet-branch}/public-api.html
06:00:42 INFO:build_docs:   - en/apm/agent/rum-js/{apm-rum-branch}/react-integration.html

[bmorelli25]

@nik9000 SMART. Thank you for doing that. I'll look into those links.

[bmorelli25]

So this is really interesting. These broken links are in the stack docs, but they're only there because they're included via a tagged region. The links really live in the APM Overview. Specifically, this page, where they work 🤔. For some reason, the attributes for :apm-dotnet-branch: and :apm-rum-branch: aren't making it to the stack docs.

[bmorelli25]

Ahhh, this could be because the stack-docs only just started using the shared version file at 4:29pm GMT yesterday (elastic/stack-docs#512) and @nik9000 started the rebuild test on this PR at 3:55pm GMT yesterday. I think if I rebuild again this should be fixed.

@elasticmachine, run elasticsearch-ci/docs rebuild

[bmorelli25]

@elasticmachine, run elasticsearch-ci/docs rebuild

[bmorelli25]

Alright, I'm officially stuck. This PR build keeps failing on the ESS docs, which should be unrelated:

ERROR building Elasticsearch Service - Hosted Elasticsearch and Kibana branch release-ms-25

I ran a rebuild in elastic/docs and it passed with flying colors: https://elasticsearch-ci.elastic.co/job/elastic+docs+master+build/4946/console

[nik9000]

Have you tried merging master into your PR? Sometimes PR branches to docs get out of date in funny ways that cause book builds to fail.

…

On Tue, Sep 17, 2019, 07:28 Brandon Morelli ***@***.***> wrote: Alright, I'm officially stuck. This build keeps failing on ESS: ERROR building Elasticsearch Service - Hosted Elasticsearch and Kibana branch release-ms-25 I ran a rebuild in elastic/docs and it passed with flying colors: https://elasticsearch-ci.elastic.co/job/elastic+docs+master+build/4946/console — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1187?email_source=notifications&email_token=AABUXIWF36HNJNXATMP3MFLQKC5MNA5CNFSM4IWNHTL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD64GWMI#issuecomment-532179761>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABUXIRAY2Z3HUZWYEEDUPDQKC5MNANCNFSM4IWNHTLQ> .

[bmorelli25]

🤦‍♂ Yeah, that worked. Going to do one more rebuild just to be safe, but the recent ci/docs was just green.

@elasticmachine, run elasticsearch-ci/docs rebuild

[bmorelli25]

Actually, it didn't work. Same ESS failure: https://elasticsearch-ci.elastic.co/job/elastic+docs+docs+pull-request/271/console

[bmorelli25]

@elasticmachine, run elasticsearch-ci/docs rebuild

[bmorelli25]

Nik's fix worked! Now the problem is about 300 broken links due to unresolved attributes.

I believe this is happening because APM Server isn't yet using the shared version file (where the attributes are described). I think I need to merge and backport elastic/apm-server#2712 simultaneously with this PR. I should be able to merge elastic/apm-server#2712 and backport it without any problems. Then I can merge this PR.

[bmorelli25]

I'm not going to remove the -v branches in this PR. There are waaaaaay to many moving pieces and this has been a nightmare tracking down broken links.

I'm taking this PR back to its roots by simply adding APM Server and APM Agents to the shared versioning files.

[bmorelli25]

@elasticmachine, run elasticsearch-ci/docs rebuild

[bmorelli25]

@elasticmachine, run elasticsearch-ci/docs rebuild

[bmorelli25]

After many, many attempts at this, the docs/ci rebuild is finally green.