-
Notifications
You must be signed in to change notification settings - Fork 347
Replace ecs version with attribute #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@webmat FYI: More steps toward implementing ECS versioning |
|
@dedemorton Here are the ECS versioning changes. Both LS and Beats handle versioning in the repo. Toward your vision outlined in #804, I'm considering switching Logstash to use this versioning approach. I'd appreciate your eyes on this PR (elastic/logstash#11125) to make sure I'm not overlooking any constraints. |
|
run elasticsearch-ci/docs rebuild |
|
@bmorelli25 If I'm interpreting the CI errors correctly, we might need to add a link to shared versions (include::{asciidoc-dir}/../../shared/versions/stack/{source_branch}.asciidoc[]) in https://raw.githubusercontent.com/elastic/apm-agent-python/master/docs/index.asciidoc If that's the right fix, I'm happy to make the fix and tag you as a reviewer. Let's discuss. |
|
Ahhh good find. Yup, looks like we probably need to include that file in all of the APM Agents to be safe. |
|
Will that work though? There are no asciidoc files in https://github.com/elastic/docs/tree/master/shared/versions/stack that match the current python version of This why we currently hardcode |
|
@karenzone Now that you've pointed this out, I'm seeing the same problem in #1187 with Agent to Agent links also failing because they don't include the shared version file. I noticed you have the ECS docs including
|
|
run elasticsearch-ci/docs rebuild |
|
@karenzone I just merged the backport. You may want to restart this build. I think it will fail as it was started before that PR was merged. |
|
run elasticsearch-ci/docs rebuild |
lcawl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, congrats!
Related to #1169
This PR replaces the hard-coded ECS version number with an attribute that supports versioning.
DO NOT MERGE until all books using the hard-coded ECS attribute have been updated to include
//shared/versions/stack/{source_branch}.asciidoc(or handled in product repo versioning)