-
Notifications
You must be signed in to change notification settings - Fork 347
Create "current" stack version file #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file will be useful for books that *generally* want to point the current release of the stack. We'll update it when we release a new version of the stack.
|
@bmorelli25 I've tried to summarize why I think we want this file in the README that I created. @lcawl, we talked a while back about maybe wanting this file. It turns out that @bmorelli25 wants it for APM. If we merge this we really should update the docs release instructions. Could you have a look at this and approve or reject it? |
shared/versions/stack/README
Outdated
|
|
||
| Books outside of the stack have three choices: | ||
|
|
||
| 1. Don't use these versions files at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I don't think this is really an option any more. With the shared version change, if I want to use any of the shared attributes in the APM Agents, they also have to use the shared version files. An example of why is in the recent ECS PR: #1170.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, ok, technically it is an option still. But I would have to start setting attribute values in each of the Agent's index.asciidoc files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I should just drop it from the list then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
bmorelli25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I don't have a problem with this "current.asciidoc" solution. I think it will still incur some of the usual problems where updating that file will result in broken links, since we invariably have pages that existing in Version X but don't exist anymore in Version X+1. If we can freeze the docs and stage that change to current.asciidoc, it buys us a bit more time to clean up links like that. |
karenzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
We can delay bumping current.asciidoc if we have to. That'd mean that things outside the stack don't point to the most current version of the stack for a little while. That seems "ok" while we're resolving broken links. |
That sounds reasonable to me. I think we'll also be able to see the full list of broken links in the PR that bumps current.asciidoc, as long as we remember to do a full rebuild test there. |
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
|
I was also interested in this solution to keep ECK code samples pointing to the current released version of the stack. However, |
I think I just made a mistake there. |
This file will be useful for books that generally want to point the
current release of the stack. We'll update it when we release a new
version of the stack.