Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 19, 2019

This file will be useful for books that generally want to point the
current release of the stack. We'll update it when we release a new
version of the stack.

This file will be useful for books that *generally* want to point the
current release of the stack. We'll update it when we release a new
version of the stack.
@nik9000
Copy link
Member Author

nik9000 commented Sep 19, 2019

@bmorelli25 I've tried to summarize why I think we want this file in the README that I created.

@lcawl, we talked a while back about maybe wanting this file. It turns out that @bmorelli25 wants it for APM. If we merge this we really should update the docs release instructions. Could you have a look at this and approve or reject it?


Books outside of the stack have three choices:

1. Don't use these versions files at all.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I don't think this is really an option any more. With the shared version change, if I want to use any of the shared attributes in the APM Agents, they also have to use the shared version files. An example of why is in the recent ECS PR: #1170.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, ok, technically it is an option still. But I would have to start setting attribute values in each of the Agent's index.asciidoc files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should just drop it from the list then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nik9000! It's not a perfect solution, but I think this will simplify things quite a bit for the APM Agent books. Curious to hear @lcawl's input.

@lcawl
Copy link
Contributor

lcawl commented Sep 19, 2019

I don't have a problem with this "current.asciidoc" solution. I think it will still incur some of the usual problems where updating that file will result in broken links, since we invariably have pages that existing in Version X but don't exist anymore in Version X+1. If we can freeze the docs and stage that change to current.asciidoc, it buys us a bit more time to clean up links like that.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
@nik9000
Copy link
Member Author

nik9000 commented Sep 19, 2019

If we can freeze the docs and stage that change to current.asciidoc, it buys us a bit more time to clean up links like that.

We can delay bumping current.asciidoc if we have to. That'd mean that things outside the stack don't point to the most current version of the stack for a little while. That seems "ok" while we're resolving broken links.

@lcawl
Copy link
Contributor

lcawl commented Sep 19, 2019

We can delay bumping current.asciidoc if we have to. That'd mean that things outside the stack don't point to the most current version of the stack for a little while. That seems "ok" while we're resolving broken links.

That sounds reasonable to me. I think we'll also be able to see the full list of broken links in the PR that bumps current.asciidoc, as long as we remember to do a full rebuild test there.

nik9000 and others added 2 commits September 19, 2019 13:22
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
@charith-elastic
Copy link
Contributor

I was also interested in this solution to keep ECK code samples pointing to the current released version of the stack. However, current.asciidoc is pointing to 7.4 -- which is yet to be released. Is that because the release is imminent?

@nik9000
Copy link
Member Author

nik9000 commented Sep 23, 2019

I was also interested in this solution to keep ECK code samples pointing to the current released version of the stack. However, current.asciidoc is pointing to 7.4 -- which is yet to be released. Is that because the release is imminent?

I think I just made a mistake there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants