actions: run unit-tests and linting in GH actions by v1v · Pull Request #3138 · elastic/e2e-testing

v1v · 2022-10-19T17:05:13Z

What does this PR do?

Use GitHub actions for the static code analysis and unit tests
Bump go version

Why is it important?

This will help with running faster builds in the CI

Issue

Requires #3139

This will help with running faster builds

mergify · 2022-10-19T17:05:52Z

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit
NOTE: backport-skip has been added to this pull request.

elasticmachine · 2022-10-19T18:05:30Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-11-07T09:25:42.430+0000
Duration: 57 min 7 sec

Test stats 🧪

Test	Results
Failed	1
Passed	34
Skipped	0
Total	35

Test errors

Expand to view the tests failures

`Initializing / End-To-End Tests / kubernetes-autodiscover_debian_10_amd64_elastic-agent / Logs collection from a pod with an init container – elastic-agent standalone`

Expand to view the error details

 Step "elastic-agent" collects events with "kubernetes.container.name:container-in-pod"

no stacktrace

Steps errors

Expand to view the steps failures

`Start Elastic Stack`

Took 11 min 50 sec . View more details here
Description: make -C .ci start-elastic-stack

`Run tests in the node`

Took 16 min 34 sec . View more details here
Description: make -C .ci run-tests

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'hudson.AbortException: script returned exit code 2'

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

Name: Initializing / End-To-End Tests / kubernetes-autodiscover_debian_10_amd64_elastic-agent / Logs collection from a pod with an init container – elastic-agent standalone

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

v1v · 2022-10-19T20:41:29Z

+        run: |
+          go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.50.0
+          go install golang.org/x/lint/golint


Force to bump the version to 1.18 so I could use go install

v1v · 2022-10-19T20:41:49Z

@@ -1 +1 @@
-1.17
+1.18


I guess this should not cause any issues, but let's wait for the whole e2e-testing runs in the CI

v1v · 2022-10-19T20:42:35Z

            (?x)^(
                .*/?\.*.(tar.gz)
            )$
-    -   id: check-jjbb


Remove the dependency with the internal docker registry, as the docker image is in the private repo and vault/docker login with secrets won't work for PRs.

faster builds

v1v · 2022-10-31T15:24:42Z

+  pre-commit:
+    runs-on: ubuntu-latest
+    env:
+      JENKINS_URL: https://beats-ci.elastic.co/
+    steps:
+      - uses: actions/checkout@v3


elastic/apm-pipeline-library#1924 could be useful in addition to https://docs.github.com/en/actions/creating-actions/creating-a-composite-action#testing-out-your-action-in-a-workflow

v1v · 2022-11-04T15:01:12Z

+    runs-on: ubuntu-latest
+    steps:
+      - uses: dorny/test-reporter@c9b3d0e2bd2a4e96aaf424dbaa31c46b42318226
+        with:
+          artifact: test-results            # artifact name
+          name: JUnit Tests                 # Name of the check run which will be created
+          path: "**/*.xml"                   # Path to test results (inside artifact .zip)
+          reporter: java-junit              # Format of test results


Wait for elastic/apm-pipeline-library#1941

(cherry picked from commit 4e9f87f) # Conflicts: # .go-version

(cherry picked from commit 4e9f87f)

(cherry picked from commit 4e9f87f) Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

…ons (#3199)

actions: run uts, linting and docs in GH actions

30db52f

This will help with running faster builds

mergify Bot added the backport-skip Skip notification from the automated backport with mergify label Oct 19, 2022

action: run in parallel

8e1a57f

v1v commented Oct 19, 2022

View reviewed changes

Comment thread .github/workflows/pull-request.yml Outdated

v1v added 4 commits October 19, 2022 21:18

action: secrets on PRs don't work atm

58a4dd9

action: golangci, install deps and remove jjb validation

95ba269

action: install go and fix no arg

060cdcc

bump version for golang

14ade8a

v1v changed the title ~~actions: run uts, linting and docs in GH actions~~ actions: run unit-tests and linting in GH actions Oct 19, 2022

Merge branch 'main' into feature/decouple-e2e-testing

6d3f37c

v1v commented Oct 19, 2022

View reviewed changes

v1v marked this pull request as ready for review October 19, 2022 20:42

v1v and others added 3 commits October 19, 2022 21:44

ci: there is no need to delete/unstash for the first stage

d9b46bc

faster builds

Merge branch 'main' into feature/decouple-e2e-testing

318d73d

Merge branch 'main' into feature/decouple-e2e-testing

c828b52

v1v commented Oct 31, 2022

View reviewed changes

Merge branch 'main' into feature/decouple-e2e-testing

cafec31

v1v requested review from a team November 2, 2022 13:44

v1v self-assigned this Nov 2, 2022

v1v added backport-v7.17.0 Automated backport with mergify backport-v8.5.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Nov 2, 2022

kuisathaverat approved these changes Nov 2, 2022

View reviewed changes

v1v commented Nov 2, 2022

View reviewed changes

Comment thread .github/workflows/junit-test-reporter.yml Outdated

Comment thread .github/workflows/junit-test-reporter.yml Outdated

Comment thread .github/workflows/junit-test-reporter.yml Outdated

Apply suggestions from code review

94c7220

cachedout reviewed Nov 3, 2022

View reviewed changes

Comment thread .github/workflows/pull-request.yml

v1v commented Nov 4, 2022

View reviewed changes

cachedout approved these changes Nov 5, 2022

View reviewed changes

v1v commented Nov 7, 2022

View reviewed changes

Comment thread .github/workflows/junit-test-reporter.yml Outdated

Update .github/workflows/junit-test-reporter.yml

4e301b4

v1v merged commit 4e9f87f into elastic:main Nov 7, 2022

mergify Bot pushed a commit that referenced this pull request Nov 7, 2022

actions: run unit-tests and linting in GH actions (#3138)

97b4d8b

(cherry picked from commit 4e9f87f) # Conflicts: # .go-version

This was referenced Nov 7, 2022

[7.17](backport #3138) actions: run unit-tests and linting in GH actions #3199

Merged

[8.5](backport #3138) actions: run unit-tests and linting in GH actions #3200

Merged

mergify Bot pushed a commit that referenced this pull request Nov 7, 2022

actions: run unit-tests and linting in GH actions (#3138)

89dd5b9

(cherry picked from commit 4e9f87f)

v1v added a commit that referenced this pull request Nov 7, 2022

actions: run unit-tests and linting in GH actions (#3138) (#3200)

71f4e77

(cherry picked from commit 4e9f87f) Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

v1v pushed a commit that referenced this pull request Nov 9, 2022

[7.17](backport #3138) actions: run unit-tests and linting in GH acti…

31354ec

…ons (#3199)

		@@ -1 +1 @@
		1.17
		1.18

Conversation

v1v commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Issue

Uh oh!

mergify Bot commented Oct 19, 2022

Uh oh!

elasticmachine commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Tests Failed

Build stats

Test stats 🧪

Test errors

Initializing / End-To-End Tests / kubernetes-autodiscover_debian_10_amd64_elastic-agent / Logs collection from a pod with an init container – elastic-agent standalone

Steps errors

Start Elastic Stack

Run tests in the node

Error signal

🐛 Flaky test report

Genuine test errors

🤖 GitHub comments

Uh oh!

Uh oh!

v1v Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

v1v Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

v1v Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

v1v Oct 31, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

v1v Nov 4, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

v1v commented Oct 19, 2022 •

edited

Loading

elasticmachine commented Oct 19, 2022 •

edited

Loading

`Initializing / End-To-End Tests / kubernetes-autodiscover_debian_10_amd64_elastic-agent / Logs collection from a pod with an init container – elastic-agent standalone`

`Start Elastic Stack`

`Run tests in the node`

`Error signal`