This repository was archived by the owner on Sep 17, 2024. It is now read-only.
kibana: fail on error and improve log messages#3190
Merged
AndersonQ merged 5 commits intoelastic:mainfrom Nov 4, 2022
Merged
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
|
Contributor
kuisathaverat
approved these changes
Nov 3, 2022
mergify Bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
(cherry picked from commit 524dbcc)
AndersonQ
added a commit
that referenced
this pull request
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When parsing KINABA_URL it fail on error and improve the logging.
Why is it important?
It improves our ability to quickly diagnose an issue when the tests fail
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have run the Unit tests (make unit-test), and they are passing locally- [ ] I have run the End-2-End tests for the suite I'm working on, and they are passing locally- [ ] I have noticed new Go dependencies (runmake noticein the proper directory)Related issues