Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

kibana: fail on error and improve log messages#3190

Merged
AndersonQ merged 5 commits intoelastic:mainfrom
AndersonQ:improve-log
Nov 4, 2022
Merged

kibana: fail on error and improve log messages#3190
AndersonQ merged 5 commits intoelastic:mainfrom
AndersonQ:improve-log

Conversation

@AndersonQ
Copy link
Copy Markdown
Member

@AndersonQ AndersonQ commented Nov 3, 2022

What does this PR do?

When parsing KINABA_URL it fail on error and improve the logging.

Why is it important?

It improves our ability to quickly diagnose an issue when the tests fail

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have run the Unit tests (make unit-test), and they are passing locally
    - [ ] I have run the End-2-End tests for the suite I'm working on, and they are passing locally
    - [ ] I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Nov 3, 2022

This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify Bot added the backport-skip Skip notification from the automated backport with mergify label Nov 3, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-04T13:22:02.495+0000

  • Duration: 68 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 216
Skipped 0
Total 216

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@AndersonQ AndersonQ merged commit 524dbcc into elastic:main Nov 4, 2022
@AndersonQ AndersonQ added the backport-v8.5.0 Automated backport with mergify label Nov 4, 2022
@AndersonQ AndersonQ self-assigned this Nov 4, 2022
@mergify mergify Bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 4, 2022
mergify Bot pushed a commit that referenced this pull request Nov 4, 2022
@AndersonQ AndersonQ deleted the improve-log branch November 4, 2022 14:47
AndersonQ added a commit that referenced this pull request Nov 9, 2022
(cherry picked from commit 524dbcc)

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport-v8.5.0 Automated backport with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants