Skip to content

Make all beats receiver integration tests use standard tools #10717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

Make all beats receiver integration tests use standard tools #10717

merged 1 commit into from
Oct 22, 2025

Conversation

@swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Oct 22, 2025 •
edited
Loading

What does this PR do?

Makes the remaining beats receiver integration tests install agent using the standard test fixture, rather than running the command directly.

Why is it important?

This way, the fixture takes care of stopping and uninstalling agent if the test fails, as well as collecting diagnostics.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Related issues

@swiatekm
Make all beats receiver integration tests use standard tools
c6dcbf9 
This way, the tests generate diagnostics and ensure agent is not running
after test failure.
@swiatekm swiatekm requested a review from a team as a code owner October 22, 2025 16:35
@swiatekm swiatekm added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team flaky-test Unstable or unreliable test cases. skip-changelog backport-8.19 Automated backport to the 8.19 branch labels Oct 22, 2025
@swiatekm swiatekm added backport-9.1 Automated backport to the 9.1 branch backport-9.2 Automated backport to the 9.2 branch labels Oct 22, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 22, 2025 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @swiatekm

@swiatekm swiatekm enabled auto-merge (squash) October 22, 2025 19:35
@swiatekm swiatekm merged commit 020adf8 into main Oct 22, 2025
34 checks passed
@swiatekm swiatekm deleted the test/improve-metrics-integration-test branch October 22, 2025 19:50
mergify bot pushed a commit that referenced this pull request Oct 22, 2025
@swiatekm @mergify
Make all beats receiver integration tests use standard tools (#10717)
2cec9a3 
This way, the tests generate diagnostics and ensure agent is not running
after test failure.

(cherry picked from commit 020adf8)
@mergify mergify bot mentioned this pull request Oct 22, 2025
Merged
3 tasks
mergify bot pushed a commit that referenced this pull request Oct 22, 2025
@swiatekm @mergify
Make all beats receiver integration tests use standard tools (#10717)
cfd0a47 
This way, the tests generate diagnostics and ensure agent is not running
after test failure.

(cherry picked from commit 020adf8)
mergify bot pushed a commit that referenced this pull request Oct 22, 2025
@swiatekm @mergify
Make all beats receiver integration tests use standard tools (#10717)
6d77781 
This way, the tests generate diagnostics and ensure agent is not running
after test failure.

(cherry picked from commit 020adf8)

# Conflicts:
#	testing/integration/ess/beat_receivers_test.go
This was referenced Oct 22, 2025
Open
Merged
swiatekm added a commit that referenced this pull request Oct 23, 2025
@mergify @swiatekm
Make all beats receiver integration tests use standard tools (#10717) (…
e5d5214 
…#10721)

This way, the tests generate diagnostics and ensure agent is not running
after test failure.

(cherry picked from commit 020adf8)

Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm added a commit that referenced this pull request Oct 23, 2025
@mergify @swiatekm
Make all beats receiver integration tests use standard tools (#10717) (…
a6f9393 
…#10719)

This way, the tests generate diagnostics and ensure agent is not running
after test failure.

(cherry picked from commit 020adf8)

Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebeahan ebeahan ebeahan approved these changes

@leehinman leehinman leehinman approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@swiatekm swiatekm

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch backport-9.2 Automated backport to the 9.2 branch flaky-test Unstable or unreliable test cases. skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swiatekm @elasticmachine @ebeahan @leehinman