Skip to content

[9.1] (backport #10717) Make all beats receiver integration tests use standard tools #10720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 9.1
Choose a base branch
from
Open

[9.1] (backport #10717) Make all beats receiver integration tests use standard tools #10720

wants to merge 3 commits into from
+8 −33

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 22, 2025

What does this PR do?

Makes the remaining beats receiver integration tests install agent using the standard test fixture, rather than running the command directly.

Why is it important?

This way, the fixture takes care of stopping and uninstalling agent if the test fails, as well as collecting diagnostics.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Related issues

This is an automatic backport of pull request #10717 done by [Mergify](https://mergify.com).

@swiatekm @mergify
Make all beats receiver integration tests use standard tools (#10717)
6d77781 
This way, the tests generate diagnostics and ensure agent is not running
after test failure.

(cherry picked from commit 020adf8)

# Conflicts:
#	testing/integration/ess/beat_receivers_test.go
@mergify mergify bot requested a review from a team as a code owner October 22, 2025 19:52
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 22, 2025
@mergify mergify bot requested review from pchila and ycombinator and removed request for a team October 22, 2025 19:52
@mergify
Copy link
Contributor Author

mergify bot commented Oct 22, 2025

Cherry-pick of 020adf8 has failed:

On branch mergify/bp/9.1/pr-10717
Your branch is up to date with 'origin/9.1'.

You are currently cherry-picking commit 020adf82d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   testing/integration/ess/beat_receivers_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team flaky-test Unstable or unreliable test cases. skip-changelog labels Oct 22, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@swiatekm swiatekm closed this Oct 23, 2025
@swiatekm swiatekm deleted the mergify/bp/9.1/pr-10717 branch October 23, 2025 10:06
@cmacknz cmacknz restored the mergify/bp/9.1/pr-10717 branch October 24, 2025 14:20
@cmacknz
Copy link
Member

cmacknz commented Oct 24, 2025

We do see this test failing in 9.1 https://buildkite.com/elastic/elastic-agent-extended-testing/builds/10840

Why did we not backport this?

@cmacknz cmacknz reopened this Oct 24, 2025
@swiatekm
Copy link
Contributor

We do see this test failing in 9.1 https://buildkite.com/elastic/elastic-agent-extended-testing/builds/10840

Why did we not backport this?

It had annoying conflicts and #10759 addressed the breakage anyway. But maybe it's worth it for consistency's sake? Let me have a look.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 24, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @swiatekm

@swiatekm
Copy link
Contributor

#10507 needs to go in first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

At least 1 approving review is required to merge this pull request.

Assignees

@swiatekm swiatekm

Labels

backport conflicts There is a conflict in the backported pull request flaky-test Unstable or unreliable test cases. skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elasticmachine @cmacknz @swiatekm @ebeahan