Skip to content

Conversation

@kaanyalti
Copy link

  • Enhancement

What does this PR do?

Updates exlcudeded error strings in the logs_ingestion_test

Why is it important?

Error messages generated by the "add_cloud_metadata" processor have been updated as shown here. These changes break the test case that is the subject of this PR.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the [changelog tool](https://github.com/elastic/elastic-agent#changelog)
  • [ ] I have added an integration test or an E2E test

@kaanyalti kaanyalti requested a review from a team as a code owner November 14, 2024 19:49
@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 14, 2024
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should one day downgrade these errors in beats to warnings since most of them are safe to ignore.

@cmacknz cmacknz added backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify labels Nov 14, 2024
@elastic-sonarqube
Copy link

@ycombinator ycombinator enabled auto-merge (squash) November 14, 2024 22:20
@ycombinator ycombinator merged commit cbb08c9 into elastic:main Nov 14, 2024
14 of 15 checks passed
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
* fix: updated excluded error strings

* fix: added error string

(cherry picked from commit cbb08c9)
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
* fix: updated excluded error strings

* fix: added error string

(cherry picked from commit cbb08c9)
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
* fix: updated excluded error strings

* fix: added error string

(cherry picked from commit cbb08c9)
kaanyalti pushed a commit that referenced this pull request Nov 15, 2024
* fix: updated excluded error strings

* fix: added error string

(cherry picked from commit cbb08c9)

Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>
blakerouse pushed a commit to blakerouse/elastic-agent that referenced this pull request Nov 18, 2024
* fix: updated excluded error strings

* fix: added error string
@pazone pazone mentioned this pull request Nov 18, 2024
7 tasks
kaanyalti pushed a commit that referenced this pull request Nov 19, 2024
* fix: updated excluded error strings

* fix: added error string

(cherry picked from commit cbb08c9)
kaanyalti pushed a commit that referenced this pull request Nov 19, 2024
* fix: updated excluded error strings

* fix: added error string

(cherry picked from commit cbb08c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants