Skip to content

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Jun 8, 2023

This PR updates the terraform shell script so the file used as a health check is written once the outputs have been saved to a file.

This will ensure that elastic-package would have available the JSON output contents when the container is considered healthy.

Closes #1299

@bhapas
Copy link
Contributor

bhapas commented Jun 8, 2023

/test

@mrodm mrodm force-pushed the test_aws_tf_outputs branch from a26a61a to 6015c9f Compare June 9, 2023 07:40
@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

3 similar comments
@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

@bhapas
Copy link
Contributor

bhapas commented Jun 9, 2023

/test

@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

@bhapas
Copy link
Contributor

bhapas commented Jun 9, 2023

/test

1 similar comment
@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

@mrodm mrodm changed the title Test aws tf outputs Set terraform healthcheck after writing outputs Jun 9, 2023
@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

1 similar comment
@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2023

/test

@mrodm
Copy link
Contributor Author

mrodm commented Jun 12, 2023

/test

@mrodm mrodm marked this pull request as ready for review June 12, 2023 09:07
@mrodm mrodm requested review from a team and bhapas June 12, 2023 09:07
@mrodm mrodm self-assigned this Jun 12, 2023
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mild nit. LGTM otherwise

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm merged commit 54d9728 into elastic:main Jun 13, 2023
@mrodm mrodm deleted the test_aws_tf_outputs branch June 13, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform outputs in aws package make the test flaky

4 participants