New Data Tiers role support #1613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should adress #1612
jbaiera
approved these changes
Mar 8, 2021
Member
jbaiera
left a comment
jbaiera
left a comment
There was a problem hiding this comment.
LGTM, thanks for putting this up!
jbaiera
pushed a commit
to jbaiera/elasticsearch-hadoop
that referenced
this pull request
Mar 8, 2021
Should adress elastic#1612
jbaiera
added a commit
that referenced
this pull request
Mar 8, 2021
jbaiera
pushed a commit
to jbaiera/elasticsearch-hadoop
that referenced
this pull request
Mar 8, 2021
Should adress elastic#1612
jbaiera
added a commit
that referenced
this pull request
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should adress #1612
I am just proposing this PR, but feel free to trash it and be more explicit (introduce a list of valid
dataroles).It's missing unit tests.