Ambigous call on QueryContainerDescriptor<T>.Wildcard(field, value)

[Schoof-T]

NEST/Elasticsearch.Net version: 5.4

Elasticsearch version: 5.5

Description of the problem including expected versus actual behavior: After upgrading to NEST 5.4 (from 5.2.2) I get an exception on QueryContainerDescriptor.Wildcard(field, value).

The call is ambiguous between the following methods or properties: 'QueryContainerDescriptor<T>.Wildcard(Expression<Func<T, object>>, string, double?, RewriteMultiTerm?, string)' and 'QueryContainerDescriptor<T>.Wildcard(Expression<Func<T, object>>, string, double?, MultiTermQueryRewrite, string)'

I use this feature to do Wildcard searches, because the alternative Term does not work like a 'like' search.

var query = value.Contains("*") ? (Func<QueryContainerDescriptor<T>, QueryContainer>)
                            (bs => bs.Wildcard(propConfig.KeySelector, value)) : // wildcard search
                            (bs => bs.Term(propConfig.KeySelector, value)); // default term search

Steps to reproduce:

1. call .Wildcard on a QueryContainerDescriptor with 2 parameters: field, value

Misc:
I also noticed that .Wildcard is new deprecated. What is the recommended method to replace this? I can't find this in any release notes.

[russcam]

Hey @TSSchoof, that particular method call for WildCard() was deprecated in NEST 5.3.0 because of #2688. With the deprecated warning, do you see the message "Use overload that accepts MultiTermQueryRewrite"?

Looks like we didn't have a test to catch the method call ambiguity 😢 It's easily resolved by specifying rewrite though

(bs => bs.Wildcard(propConfig.KeySelector, value, rewrite:(MultiTermQueryRewrite)null))

The deprecated methods will be removed in the next major release.

[Schoof-T]

Thanks! I don't see that message though. It's probably a setting in Visual Studio somewhere? 😜

[russcam]

That's no good! Do you see it in the build output?

[Schoof-T]

Well when I'm not using the override you suggested, the build fails and I just get the exception.

The override is not deprecated so that does not show any warnings.

[russcam]

No worries, thanks for looking. I'm sure Visual Studio used to show the Obsolete message within the intellisense bubble 😕

[Schoof-T]

No problem! I would have assumed so too. Not sure if it's something with my Visual Studio (2017) or just in general.