IncludeInParent elastic property in NEST #1307 #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Strange, github shows that I have problem with formatting in |
|
I already modified the code and it works like charm. let me try to commit and see if it allows. |
Member
|
LGTM 👍 Thanks again @robertlyson :) |
Mpdreamz
added a commit
that referenced
this pull request
Apr 23, 2015
…ttributes IncludeInParent elastic property in NEST #1307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains fix for #1307.
I modified
IElasticPropertyAttributeandWritePropertiesFromAttributeVisitorto handle missing property.