Skip to content

PingTimeout does not use a time unit. #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonyadamit wants to merge 2 commits into from
Closed

PingTimeout does not use a time unit. #1657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e5277d
PingTimeout does not use a time unit.
jonyadamit Dec 10, 2015
cf07ce1
settings now contains a string.
jonyadamit Dec 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Elasticsearch.Net/Transport/Pipeline/RequestPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ public async Task PingAsync(Node node)
}
}

private string SniffPath => "_nodes/_all/settings?flat_settings&timeout=" + this.PingTimeout;
private string SniffPath => "_nodes/_all/settings?flat_settings&timeout=" + this.PingTimeout.TotalMilliseconds + "ms";

public IEnumerable<Node> SniffNodes => this._connectionPool.CreateView().ToList().OrderBy(n => n.MasterEligable ? n.Uri.Port : int.MaxValue);

Expand Down
4 changes: 2 additions & 2 deletions src/Elasticsearch.Net/Transport/Sniff/SniffResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ internal class SniffNode
public string build { get; set; }
public IDictionary<string, object> settings { get; set; }

internal bool MasterEligable => !((this.settings?.ContainsKey("node.master")).GetValueOrDefault(false) && ((bool)this.settings["node.master"]) == false);
internal bool HoldsData => !((this.settings?.ContainsKey("node.data")).GetValueOrDefault(false) && ((bool)this.settings["node.data"]) == false);
internal bool MasterEligable => !((this.settings?.ContainsKey("node.master")).GetValueOrDefault(false) && Convert.ToBoolean(this.settings["node.master"]) == false);
internal bool HoldsData => !((this.settings?.ContainsKey("node.data")).GetValueOrDefault(false) && Convert.ToBoolean(this.settings["node.data"]) == false);
}

}