Skip to content

obsolete .Highlights on SearchResponse, bad bad abstraction #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmarz merged 1 commit into from
Sep 13, 2016
Merged

obsolete .Highlights on SearchResponse, bad bad abstraction #2255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Nest/Search/Search/SearchResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ public class SearchResponse<T> : ResponseBase, ISearchResponse<T> where T : clas


private HighlightDocumentDictionary _highlights = null;
[Obsolete("This highlights by document id dictionary is the wrong abstraction in cases search can yield the same ids, scheduled for removal in 5.0 see #2168")]
/// <summary>
/// IDictionary of id -Highlight Collection for the document
/// </summary>
Expand Down