fix #2673 field stats on geo fields in elasticsearch 5.3 #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`geo_point` and `geo_shape` field types now return a `min_value` and `max_value` as per Elasticsearch 5.3 but do so as an object. This is breaking for us in 5.x so for now we keep on ignoring them. Included support for `min/max_value_as_string` which will never be null.`
gmarz
suggested changes
Mar 21, 2017
Contributor
gmarz
left a comment
gmarz
left a comment
There was a problem hiding this comment.
FieldMinMaxValueJsonConverter should be internal. This is why travis is failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geo_pointandgeo_shapefield types now return amin_valueandmax_valueas per Elasticsearch 5.3 but do so as an object. This isbreaking for us in 5.x so for now we keep on ignoring them.
Included support for
min/max_value_as_stringwhich will never benull.`