Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Apr 16, 2018

This commit updates the settings available for the s3 repository
plugin.
Add client,buffer_size,canned_acl,storage_class,server_side_encryption
Remove access_key,secret_key. Now specified in elasticsearch keystore.
Remove concurrent_streams.

Closes #3141

This commit updates the settings available for the s3 repository
plugin.
Add client,buffer_size,canned_acl,storage_class,server_side_encryption
Remove access_key,secret_key. Now specified in elasticsearch keystore.
Remove concurrent_streams.

Closes #3141
@russcam
Copy link
Contributor Author

russcam commented Apr 16, 2018

Will need to be backported to 6.x and 5.x in a BWC way i.e. existing properties should be deprecated through [Obsolete()].

Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebrain codebrain merged commit e3a38de into master Apr 20, 2018
codebrain added a commit that referenced this pull request Apr 21, 2018
codebrain added a commit that referenced this pull request Apr 21, 2018
@codebrain codebrain deleted the bug/s3-repository-settings branch April 21, 2018 06:40
russcam pushed a commit that referenced this pull request Apr 24, 2018
This commit updates the settings available for the s3 repository plugin.

Backport of #3203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants