Use AssertionScope to always include response.DebugInformation #3408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… response body Should() assertions. This changes the way assertions are executed though, reporting on all ALL the failures. Since we do quite a few assertions in a single method this would become noisy so we hack the message to only include the first failure as before
Member
Author
|
@russcam @codebrain using my discretion to pull this |
Mpdreamz
added a commit
that referenced
this pull request
Sep 18, 2018
… response body Should() assertions. This changes the way assertions are executed though, reporting on all ALL the failures. Since we do quite a few assertions in a single method this would become noisy so we hack the message to only include the first failure as before (#3408) (cherry picked from commit df95930)
Mpdreamz
added a commit
that referenced
this pull request
Sep 18, 2018
… response body Should() assertions. This changes the way assertions are executed though, reporting on all ALL the failures. Since we do quite a few assertions in a single method this would become noisy so we hack the message to only include the first failure as before (#3408) (cherry picked from commit df95930)
Member
Author
|
ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do our response testing in the API integration tests only.
This changes the way assertions are executed though, reporting on all ALL the failures.
Since we do quite a few assertions in a single method this would become noisy so we hack the message to only include the first failure as before