Skip to content

Use AssertionScope to always include response.DebugInformation #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Use AssertionScope to always include response.DebugInformation #3408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Tests/Tests/Framework/EndpointTests/ApiIntegrationTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using Elastic.Xunit.XunitPlumbing;
using Elasticsearch.Net;
using FluentAssertions;
using FluentAssertions.Execution;
using Nest;
using Tests.Core.Client;
using Tests.Core.Extensions;
Expand Down Expand Up @@ -53,7 +54,20 @@ protected override Task AssertOnAllResponses(Action<TResponse> assert)
return;
}

assert(r);
using (var scope = new AssertionScope())
{
assert(r);
var failures = scope.Discard();
if (failures.Length <= 0) return;

var failure = failures[0];
scope.AddReportable("Failure", failure);
scope.AddReportable("DebugInformation", r.DebugInformation);
scope.FailWith( $@"{{Failure}}
Response Under Test:
{{DebugInformation}}");

}
});
}
}
Expand Down
1 change: 0 additions & 1 deletion src/Tests/Tests/Search/Request/FieldsUsageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ [I] protected Task FieldsAreReturned() => this.AssertOnAllResponses(r =>
var name = fieldValues.Value<string>(Field<Project>(p => p.Name));
name.Should().NotBeNullOrWhiteSpace();


var commits = fieldValues.ValueOf<Project, float?>(p => p.NumberOfCommits);
commits.Should().BeGreaterThan(0);

Expand Down