Check backOffRetries before retrying in HandleBulkRequest #3954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BulkAll will hang indefinitely, giving no error, if a bulk request keeps coming back as BadResponse.
Contributor
|
Thanks for opening a PR, @mb1337. Do you have a reproducible test to add, that demonstrates the issue you've seen with continually returned BadResponse from BulkAll? |
Mpdreamz
added a commit
that referenced
this pull request
Aug 9, 2019
…equest keeps returning a bad statuscode
Merged
Member
codebrain
pushed a commit
that referenced
this pull request
Aug 12, 2019
…equest keeps returning a bad statuscode (#4014) Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode.
codebrain
pushed a commit
that referenced
this pull request
Aug 12, 2019
…equest keeps returning a bad statuscode (#4014) Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode.
codebrain
pushed a commit
that referenced
this pull request
Aug 12, 2019
…equest keeps returning a bad statuscode (#4014) Ensure BulkAll() is aborted properly if the whole bulk request keeps returning a bad statuscode.
russcam
pushed a commit
that referenced
this pull request
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BulkAll will hang indefinitely, giving no error, if a bulk request keeps returning BadResponse. The bulk all request should throw an error after hitting the back off retry number.