Skip to content

Check backOffRetries before retrying in HandleBulkRequest #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Check backOffRetries before retrying in HandleBulkRequest #3954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Nest/Document/Multiple/BulkAll/BulkAllObservable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,16 @@ private async Task<BulkAllResponse> HandleBulkRequest(IList<T> buffer, long page
case PipelineFailure.SniffFailure:
case PipelineFailure.Unexpected:
throw ThrowOnBadBulk(response,
$"BulkAll halted after {nameof(PipelineFailure)}{failureReason.GetStringValue()} from _bulk");
$"BulkAll halted after {nameof(PipelineFailure)}.{failureReason.GetStringValue()} from _bulk");
case PipelineFailure.BadResponse:
case PipelineFailure.PingFailure:
case PipelineFailure.MaxTimeoutReached:
case PipelineFailure.BadRequest:
default:
if (backOffRetries >= _backOffRetries)
throw ThrowOnBadBulk(response,
$"BulkAll halted after {nameof(PipelineFailure)}.{failureReason.GetStringValue()} from _bulk");

return await RetryDocuments(page, ++backOffRetries, buffer).ConfigureAwait(false);
}
}
Expand Down