Skip to content

deprecation logging should assert a minimum of 2 not exactly 2 #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2019
Merged

deprecation logging should assert a minimum of 2 not exactly 2 #4250

merged 2 commits into from
Dec 10, 2019

Conversation

@Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Dec 9, 2019

No description provided.

@Mpdreamz Mpdreamz changed the title deprecation logging should assert a minimum of 2 not extactly 2 deprecation logging should assert a minimum of 2 not exactly 2 Dec 9, 2019
russcam
russcam approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@russcam
Copy link
Contributor

russcam commented Dec 9, 2019

The failed test on AppVeyor looks flaky, and passes locally:

.\build.bat seed:95886 random:sourceserializer random:typedkeys random:httpcompression test "requestpipelines"

Opened #4254.

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Dec 10, 2019

Thanks for opening a ticket for the test 👍

@Mpdreamz Mpdreamz merged commit 169c185 into 7.x Dec 10, 2019
@Mpdreamz Mpdreamz deleted the fix/7.x/deprecation-logging-tests branch December 10, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@russcam russcam russcam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mpdreamz @russcam