Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Jul 21, 2020

No description provided.

@Mpdreamz
Copy link
Member

Soo close:

  X Tests.Indices.IndexManagement.SplitIndex.SplitIndexApiTests.ReturnsExpectedResponse [703ms]
  Error Message:
   Tests.Framework.EndpointTests.ResponseAssertionException : Expected boolean to be true, but found False.
Response Under Test:
Valid NEST response built from a successful (200) low level call on PUT: /nest-initializerasync-9379535f/_split/nest-initializerasync-9379535f-target?pretty=true&error_trace=true
# Audit trail of this API call:
 - [1] HealthyResponse: Node: http://localhost:9200/ Took: 00:00:31.0320917
# Request:
{"settings":{"index.number_of_shards":8}}
# Response:
{
  "acknowledged" : true,
  "shards_acknowledged" : false,
  "index" : "nest-initializerasync-9379535f-target"
}

shards_acknowldged is extremely unlikely to be false though

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for tackling these!

@russcam russcam merged commit 3283368 into master Jul 22, 2020
@russcam russcam deleted the infra/ci-tests branch July 22, 2020 03:24
github-actions bot pushed a commit that referenced this pull request Jul 22, 2020
This commit makes some changes to integration tests
that 
- are flaky on CI
- send data that is not valid and is now validated
- make assertions that may not hold with all test seeds
github-actions bot pushed a commit that referenced this pull request Jul 22, 2020
This commit makes some changes to integration tests
that 
- are flaky on CI
- send data that is not valid and is now validated
- make assertions that may not hold with all test seeds
russcam added a commit that referenced this pull request Jul 22, 2020
This commit makes some changes to integration tests
that 
- are flaky on CI
- send data that is not valid and is now validated
- make assertions that may not hold with all test seeds

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Jul 22, 2020
This commit makes some changes to integration tests
that 
- are flaky on CI
- send data that is not valid and is now validated
- make assertions that may not hold with all test seeds

Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants