Skip to content

Conversation

@hotchpotch
Copy link

because ActiveModel's changes_attributes keys are string.

> ar_model_object.changed_attributes
=> {"title"=>"example"}

@karmi
Copy link
Contributor

karmi commented Jun 18, 2014

Thanks, there's already #140 opened for that. AFAIK, ActiveRecord::Base returns it as Symbols, need to dig into it, to see the different implementations across ActiveRecord, ActiveModel, Mongoid, etc.

@hotchpotch
Copy link
Author

I see, thanks!

elasticsearch-ruby/rails is very useful 😄

@hotchpotch hotchpotch closed this Jun 18, 2014
@karmi
Copy link
Contributor

karmi commented Jun 18, 2014

@hotchpotch Let's keep this open, the issue still stands :)

@karmi karmi reopened this Jun 18, 2014
@hotchpotch
Copy link
Author

@karmi sorry, I understand.

@karmi
Copy link
Contributor

karmi commented Sep 9, 2014

@hotchpotch Apologies!, this has been actually implemented in f68505e, I totally forgot about this patch... Thanks again for catching it and submitting the pull request!

@karmi karmi closed this Sep 9, 2014
@hotchpotch
Copy link
Author

@karmi Thank you for your implementation 😀 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants