Inherit ServerError from Transport::Error instead of StandardError #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow rescuing raised Errors::NotFound or Errors::ServerError by rescue
Transport::Error.
Behavior is now in line with documentation: “The highest-level
exception is {Elasticsearch::Transport::Transport::Error} and will be
raised for any generic client or server errors.”
Contributor
|
Thanks!, @mlangenberg, good catch. Can you please sign the CLA so I can merge this? |
Contributor
Author
|
Sure. Just signed the CLA. |
Contributor
|
Thanks!, merged and pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an error in the documentation:
This is not true, because
Transport::ServerErrorinherits from StandardError. If yourescue Elasticsearch::Transport::Transport::Error, you would actually miss all exceptions such asNotFoundorServiceUnavailable.Behavior is now in line with documentation.
Added test may be ditched, it's a very trivial change and testing the exception hierarchy chain doesn't make much sense.